Structure the aggregator and flusher goroutines #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another chunk of #300. Once this lands the final step will be to break out the existing massive `run()` methods into useful helper functions now that parameter-passing isn't such a pain. In theory no functional changes; just slightly nicer code and stricter typing around channel direction.
|
Really straightforward 👍 |
eapache
added a commit
that referenced
this pull request
Aug 13, 2015
Structure the aggregator and flusher goroutines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another chunk of #300. Once this lands the final step will be to break out the
existing massive
run()methods into useful helper functions now thatparameter-passing isn't such a pain.
In theory no functional changes; just slightly nicer code and stricter typing
around channel direction.
@Shopify/kafka